[
https://jira.codehaus.org/browse/MSITE-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=324683#comment-324683
]
Herve Boutemy edited comment on MSITE-669 at 5/4/13 10:31 AM:
--------------------------------------------------------------
Lennard,
I started today to really review the issue and the patch.
The structure you want to do seems really complicated, and I need to better
understand: if you are available on IRC this WE, we could work together in a
more interactive way.
FYI, I split the patch in 3 parts: IT, plugin modifications, documentation.
And I started studying the IT (without applying plugin modifications), since
it's the use case I must understand before adding a new option to the plugin.
Then I modified the invoker.properties file to invoke site-deploy instead of
site:site (notice that configuring
distributionManagement.site.url=file://@project.build.directory@/it/MSITE-669/target/deploy
would make more sense).
Then I compared the content from staging and deploy directories: found no
difference!
If there is no difference, there is no problem: did I overlook something?
was (Author: hboutemy):
Lennard,
I started today to really review the issue and the patch.
The structure you want to do seems really complicated, and I need to better
understand: if you are available on IRC this WE, we could work together in a
more interactive way.
FYI, I split the patch in 3 parts: IT, plugin modifications, documentation.
And I started studying the IT (without applying plugin modifications), since
it's the use case I must understand before adding a new option to the plugin.
Then I modified the invoker.properties file to invoke site-deploy instead of
site:site (noticed that configuring
distributionManagement.site.url=file://@project.build.directory@/it/MSITE-669/target/deploy
would make more sense).
Then I compared the content from staging and deploy directories: found no
difference!
If there is no difference, there is no problem: did I overlook something?
> site:stage creates incorrect structure when module paths contains sets of
> "../"
> -------------------------------------------------------------------------------
>
> Key: MSITE-669
> URL: https://jira.codehaus.org/browse/MSITE-669
> Project: Maven 2.x and 3.x Site Plugin
> Issue Type: Bug
> Components: multi module, relative links, site:stage(-deploy)
> Affects Versions: 3.1, 3.2
> Reporter: Lennart Jorelid
> Assignee: Lukas Theussl
> Fix For: 3.3
>
> Attachments: msite_669.patch, msite_669_v2.patch, msite_669_v3.patch,
> msite_669_v4.patch, nazgul_tools_project_dependencies.png,
> nazgul_tools_reactor_structure.png, sample.zip
>
>
> Given the module definitions given below, the site:stage goal produces sets
> of maps relative to the staging directory - i.e. outside of the target
> directory.
> {code:xml}
> <modules>
> <module>../../validation/validation-api</module>
> <module>../../validation/validation-aspect</module>
> <module>../parent</module>
> </modules>
> {code}
> The staged site should be fully included within the staging directory. It
> would appear that relativization of links for site:stage should take special
> links into consideration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
