[
https://jira.codehaus.org/browse/MSHARED-295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=335569#comment-335569
]
Andrey Klochkov commented on MSHARED-295:
-----------------------------------------
Kristian,
How about making ProcessHook implementation pluggable? I.e. the sigar
dependency can be removed from the patch, and the default implementation of
ProcessHook would be replaceable with a user provided one via e.g. an
environment variable. This wouldn't change the default behavior of
CommandLineUtils and still will give an ability to solve the issues with
killing child processes for those having them.
> Non reliable killing of processes by CommandLineUtils
> -----------------------------------------------------
>
> Key: MSHARED-295
> URL: https://jira.codehaus.org/browse/MSHARED-295
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-shared-utils
> Reporter: Andrey Klochkov
> Assignee: Kristian Rosenvold
> Attachments: MSHARED-295-no-cmd.patch, MSHARED-295.patch
>
>
> CommandLineUtils is used in Maven-Surefire to start forks which execute
> tests. It is a well known issue that sometimes child processes are not killed
> correctly. This is a known limitation of JVM, and the only reliable way to
> implement it would be platform specific.
> Bug report in Surefire JIRA:
> http://jira.codehaus.org/browse/SUREFIRE-773
> JVM bug report. It's Windows specific, but the problem exists on Linux and
> OSX as well.
> http://bugs.sun.com/view_bug.do?bug_id=4770092
> I'm proposing either 1) to implement several platform specific
> implementations of ProcessHook or 2) to make the mechanism of killing
> processes extendable for clients of the library.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira