[
https://jira.codehaus.org/browse/MCHECKSTYLE-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=351623#comment-351623
]
Robert Scholte commented on MCHECKSTYLE-214:
--------------------------------------------
I don't fully agree on this one. Checkstyle is about validating the
input/sources. If you choose not to package certain files, that's up to you and
that part is controlled by the {{<build><resources>}}. If there are more files
under {{src/main/resources}}, they should be validated as well, since these are
shared with your co-workers. If there are files which should be excluded, use
the {{resourceExcludes}} parameter.
> Resources retrieval ignores resources definition in <build>
> -----------------------------------------------------------
>
> Key: MCHECKSTYLE-214
> URL: https://jira.codehaus.org/browse/MCHECKSTYLE-214
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Affects Versions: 2.11
> Reporter: Michael Osipov
> Priority: Critical
>
> Consider this snippet from a POM:
> {code}
> <build>
> <resources>
> <resource>
> <directory>src/main/resources</directory>
> </resource>
> <resource>
> <directory>${basedir}</directory>
> <targetPath>META-INF</targetPath>
> <includes>
> <include>LICENSE.txt</include>
> </includes>
> </resource>
> </resources>
> </build>
> {code}
> So, the plugin should check everything in {{src/main/resources}} and the
> {{README.txt}}, after applying plugin's resource includes only properties
> files remain. Unfortunately, all files (in this case properties) below
> {{basedir}}, including those in {{target}} are checked because the plugin
> ignores the includes/excludes in that {{Resource}} element.
> The {{Resource}} element looks like this:
> {code}
> Resource {targetPath: META-INF, filtering: false, FileSet {directory:
> D:\workspace-4.2\michael-o-tomcat-extras, PatternSet [includes:
> {LICENSE.txt}, excludes: {}]}}
> {code}
> This happens in {{DefaultCheckstyleExecutor}} in lines 578 to 584. The
> outcome is that given properties files are checked twice and generated files
> are checked to.
> We need a resembling logic like in the {{maven-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
