[
https://jira.codehaus.org/browse/MDEPLOY-189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=355365#comment-355365
]
Robert Scholte commented on MDEPLOY-189:
----------------------------------------
[DeployMojo|http://maven.apache.org/plugins/maven-deploy-plugin/xref/org/apache/maven/plugin/deploy/DeployMojo.html#L155]
refers to the code you're talking about.
I did a quick scan and to me the code seems correct and doesn't match your
story.
{code}
if ( skip )
{
getLog().info( "Skipping artifact deployment" );
}
else
{
// not interesting for this case
}
boolean projectsReady = readyProjectsCounter.incrementAndGet() ==
reactorProjects.size();
if ( projectsReady )
{
synchronized ( deployRequests )
{
while ( !deployRequests.isEmpty() )
{
deployProject( deployRequests.remove( 0 ) );
}
}
}
else if ( addedDeployRequest )
{
getLog().info( "Deploying " + project.getGroupId() + ":" +
project.getArtifactId() + ":"
+ project.getVersion() + " at end" );
}
{code}
Skip only logs, the plugin still does the check if it has reached the final
project.
Are you sure that it works when {{skip=false}} ? This might look like a weird
question, but there are edge-cases where {{deployAtEnd}} doesn't work due to
the architecture of Maven Core and which can't be fixed by the
maven-deploy-plugin.
> when skip is enabled for the final module, deployAtEnd artifacts are not
> deployed
> ---------------------------------------------------------------------------------
>
> Key: MDEPLOY-189
> URL: https://jira.codehaus.org/browse/MDEPLOY-189
> Project: Maven Deploy Plugin
> Issue Type: Bug
> Components: deploy:deploy
> Affects Versions: 2.8, 2.8.1, 2.8.2
> Environment: Maven 3.0.5 or Maven 3.1.1
> Reporter: J. Carrothers
>
> Whenever the final module in the reactor to run has skip=true, the final
> deploy phase, including any deployments to be done "at the end" by way of
> deployAtEnd are also skipped.
> A good example of this is skipping the deployment of an aggregator POM which
> is not the parent of the projects it is building and should not, itself, be
> deployed.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
