[ https://jira.codehaus.org/browse/MTOOLCHAINS-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=355878#comment-355878 ]
Markus KARG commented on MTOOLCHAINS-6: --------------------------------------- Thank you so much for your effort. This looks really promising. There are only few notes on your draft: * Please introduce hyperlinks to the mentioned IT source code, as not everybody implementing a toolchain is aware of the source location of the mentioned classes. * It is unclear, why one must extend DefaultTypechain but cannot just implement Typechain. * There is a typo "epxected" * For those not familiar with the concept of "extensions", it would be a big help if in "Using the Custom Toolchain and its Plugin" you would give clear advice, into WHICH pom.xml the particular XML snippets have to go: The toolchain, the separate plugins, or the end user's project pom? As I have to build my own toolchain in the next months, there will be a beta test for your description soon. :-) Unfortunately I will not find the time to test it before end of the year, but nevertheless, thank you so much for your work! Regards -Markus > Cannot create custom toolchain type > ----------------------------------- > > Key: MTOOLCHAINS-6 > URL: https://jira.codehaus.org/browse/MTOOLCHAINS-6 > Project: Maven Toolchains Plugin > Issue Type: Bug > Affects Versions: 1.0 > Environment: Win 7 Pro SP1 64 Bit, mvn 3.0.4, JDK 1.7.0_45 > Reporter: Markus KARG > Priority: Blocker > > The web site says that it is possible to use other toolchains besides <jdk>. > Actually the site links to a nonexistent TBD page. This is very ugly. > Please tell the truth on the web page: It is simply impossible to use any > other toolschain type besides <jdk>! > It would be really cool, if someone could simply write: > {code:xml} > <toolchains> > <type>installshield</type> > <provides> > <id>isx</id> > <version>10.0</version> > <vendor>macrovision</vendor> > </provides> > <configuration> > <installshieldHome>C:\Program Files (x86)\InstallShield > X</installshieldHome> > </configuration> > </toolchains> > {code} > ...and the plugin would in turn simply provide a property that one can read > in the POM using {{$\{installshieldHome}}} -- without any need to write Java > code, register custom types, provide more xml, whatever! > This seems to be such an obvious need that I just cannot believe that it does > not already work exactly that way in the 1.0 release of the toolchains > plugin...! :-) > I really beg for that! :-) -- This message was sent by Atlassian JIRA (v6.1.6#6162)