[ 
https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361494#comment-361494
 ] 

Tom Williamson commented on MPMD-199:
-------------------------------------

I noticed that sample.jsp was in the patch file twice, not being completely 
familiar with the patch file format I thought it might have something to do 
with the containing directory being added as well as the file itself.   I don't 
normally use Subversion and have never created patches before, always been a 
direct committer.   I have no idea why it did that, but it was not an edit that 
I put in - the patch file came directly from TortoiseSVN 1.8.10.   

You're absolutely right on the second one, but for #3 the POM file already 
contains a dependency for pmd-jsp in 3.3 - not sure why, but there was no need 
to add it.   I rebuilt the project again with a virgin copy of the original POM 
and it seems to work fine including the tests.   Am I missing something more 
than that?




> Support PMD functionality on JSP files
> --------------------------------------
>
>                 Key: MPMD-199
>                 URL: https://jira.codehaus.org/browse/MPMD-199
>             Project: Maven PMD Plugin
>          Issue Type: Improvement
>          Components: PMD
>    Affects Versions: 3.3
>            Reporter: Tom Williamson
>            Priority: Minor
>         Attachments: Jsp_support_201501201341.patch, 
> Patch_for_JSP_support.patch
>
>
> It would be great if this plugin would either support PMD functionality for 
> JSP files, or simply enable them as part of the Java support.   



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to