[ 
https://jira.codehaus.org/browse/MASSEMBLY-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361715#comment-361715
 ] 

Dawid Weiss commented on MASSEMBLY-742:
---------------------------------------

Unfortunately plexus-archiver doesn't even compile at the latest commit on 2.x 
branch (867eee8e47ee29799):
{code}
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] 
c:\Work\maven\plexus-archiver\src\main\java\org\codehaus\plexus\archiver\zip\ConcurrentJarCreator.java:[31,55]
 error: cannot find symbol
[ERROR]   symbol:   class ZipArchiveEntryRequest
  location: package org.apache.commons.compress.archivers.zip
c:\Work\maven\plexus-archiver\src\main\java\org\codehaus\plexus\archiver\zip\ConcurrentJarCreator.java:[31,0]
 error: static import only from classes and interfaces
[ERROR] 
c:\Work\maven\plexus-archiver\src\main\java\org\codehaus\plexus\archiver\zip\ConcurrentJarCreator.java:[60,36]
 error: no suitable constructor found for 
ParallelScatterZipCreator(ExecutorService,ScatterGatherBackingStoreSupplier)
[ERROR]     constructor 
ParallelScatterZipCreator.ParallelScatterZipCreator(int,ScatterGatherBackingStoreSupplier)
 is not applicable
      (actual argument ExecutorService cannot be converted to int by method 
invocation conversion)
    constructor ParallelScatterZipCreator.ParallelScatterZipCreator(int) is not 
applicable
      (actual and formal argument lists differ in length)
    constructor ParallelScatterZipCreator.ParallelScatterZipCreator() is not 
applicable
      (actual and formal argument lists differ in length)
c:\Work\maven\plexus-archiver\src\main\java\org\codehaus\plexus\archiver\zip\ConcurrentJarCreator.java:[78,40]
 error: cannot find symbol
[ERROR]   symbol:   method 
createZipArchiveEntryRequest(ZipArchiveEntry,InputStreamSupplier)
  location: class ConcurrentJarCreator
c:\Work\maven\plexus-archiver\src\main\java\org\codehaus\plexus\archiver\zip\ConcurrentJarCreator.java:[83,37]
 error: cannot find symbol
{code}

How come it worked for you?

> Unclosed ZipFile warnings when ZIP archives are included
> --------------------------------------------------------
>
>                 Key: MASSEMBLY-742
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-742
>             Project: Maven Assembly Plugin
>          Issue Type: Bug
>          Components: dependencySet
>    Affects Versions: 2.5.2
>            Reporter: Dawid Weiss
>            Assignee: Kristian Rosenvold
>            Priority: Minor
>             Fix For: 2.5.3, 2.5.4
>
>         Attachments: example.zip
>
>
> I get the following warnings at the end of Maven build:
> {code}
> Cleaning up unclosed ZipFile for archive C:\...foo-0.2.0-SNAPSHOT.zip
> {code}
> These warnings originate from assembly plugin, but in fact they're caused by 
> the fact that plexus resource abstraction opens up a ZipFile from 
> commons-compress, but never closes it. Commons-compress then force-closes all 
> such objects in finalize, emitting a warning.
> I created a synthetic capture of the allocation stack in maven assembly, it's 
> here:
> {code}
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:211)
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:193)
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:154)
> org.codehaus.plexus.archiver.zip.PlexusIoZipFileResourceCollection.getEntries(PlexusIoZipFileResourceCollection.java:29)
> org.codehaus.plexus.components.io.resources.AbstractPlexusIoArchiveResourceCollection.getResources(AbstractPlexusIoArchiveResourceCollection.java:69)
> org.codehaus.plexus.components.io.resources.proxy.PlexusIoProxyResourceCollection.getResources(PlexusIoProxyResourceCollection.java:111)
> org.codehaus.plexus.archiver.AbstractArchiver$1.hasNext(AbstractArchiver.java:493)
> org.codehaus.plexus.archiver.dir.DirectoryArchiver.execute(DirectoryArchiver.java:71)
> org.codehaus.plexus.archiver.AbstractArchiver.createArchive(AbstractArchiver.java:940)
> org.apache.maven.plugin.assembly.archive.archiver.AssemblyProxyArchiver.createArchive(AssemblyProxyArchiver.java:541)
> org.apache.maven.plugin.assembly.archive.DefaultAssemblyArchiver.createArchive(DefaultAssemblyArchiver.java:180)
> org.apache.maven.plugin.assembly.mojos.AbstractAssemblyMojo.execute(AbstractAssemblyMojo.java:486)
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:347)
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:154)
> org.apache.maven.cli.MavenCli.execute(MavenCli.java:582)
> org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
> org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
> sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> java.lang.reflect.Method.invoke(Method.java:483)
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> {code}
> Hope this helps, somehow.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to