[
https://issues.apache.org/jira/browse/MESOS-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014368#comment-15014368
]
Jie Yu commented on MESOS-3961:
-------------------------------
The container path in the volume will be ignored because, as the note stated,
how this resource is used has nothing to do with the Resource object itself
(and it's equality check). We'll still check if persistence id matches or not
before deleting the disk resource with persistent volume.
> Consider equality behavior for DiskInfo resource
> ------------------------------------------------
>
> Key: MESOS-3961
> URL: https://issues.apache.org/jira/browse/MESOS-3961
> Project: Mesos
> Issue Type: Bug
> Reporter: Neil Conway
> Priority: Minor
> Labels: mesosphere, persistent-volumes
>
> Relevant code:
> {code}
> bool operator==(const Resource::DiskInfo& left, const Resource::DiskInfo&
> right)
> {
> // NOTE: We ignore 'volume' inside DiskInfo when doing comparison
> // because it describes how this resource will be used which has
> // nothing to do with the Resource object itself. A framework can
> // use this resource and specify different 'volume' every time it
> // uses it.
> if (left.has_persistence() != right.has_persistence()) {
> return false;
> }
> if (left.has_persistence()) {
> return left.persistence().id() == right.persistence().id();
> }
> return true;
> }
> {code}
> A consequence of this behavior is that if you pass the wrong path to a
> `destroy-volume` request (but there is a persistent volume that otherwise
> matches the request), the path will be ignored and the volume will be
> destroyed. Not clear if that is undesirable, but it does seem surprising.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
