[
https://issues.apache.org/jira/browse/MESOS-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014400#comment-15014400
]
Jie Yu commented on MESOS-3961:
-------------------------------
Yeah, I agree that's an unfortunate situation. Also, I've got questions like
why the user has to specify a 'volume' when creating a persistent disk resource
(but not yet launching a task). I think we need to re-think those problems.
Thanks for filing the ticket.
>From the implementation perspective, we did that because the master will
>perform 'contains' check to make sure a task is not using resources that are
>not offered to it. If we don't ignore 'volume', that means the framework
>cannot change 'container_path' once the volume is created. That's a bit
>unfortunate as well.
> Consider equality behavior for DiskInfo resource
> ------------------------------------------------
>
> Key: MESOS-3961
> URL: https://issues.apache.org/jira/browse/MESOS-3961
> Project: Mesos
> Issue Type: Bug
> Reporter: Neil Conway
> Priority: Minor
> Labels: mesosphere, persistent-volumes
>
> Relevant code:
> {code}
> bool operator==(const Resource::DiskInfo& left, const Resource::DiskInfo&
> right)
> {
> // NOTE: We ignore 'volume' inside DiskInfo when doing comparison
> // because it describes how this resource will be used which has
> // nothing to do with the Resource object itself. A framework can
> // use this resource and specify different 'volume' every time it
> // uses it.
> if (left.has_persistence() != right.has_persistence()) {
> return false;
> }
> if (left.has_persistence()) {
> return left.persistence().id() == right.persistence().id();
> }
> return true;
> }
> {code}
> A consequence of this behavior is that if you pass the wrong path to a
> `destroy-volume` request (but there is a persistent volume that otherwise
> matches the request), the path will be ignored and the volume will be
> destroyed. Not clear if that is undesirable, but it does seem surprising.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
