[ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254343#comment-16254343 ]
Benjamin Mahler commented on MESOS-6972: ---------------------------------------- Move support for install handlers is committed: {noformat} commit 8cd1bd2fcb8a4d2330a781a86b62e55ada6d4984 (HEAD -> master, apache/master, apache/HEAD) Author: Dmitry Zhuk <dz...@twopensource.com> Date: Wed Nov 15 14:19:39 2017 -0800 Enabled rvalue reference parameters in protobuf handlers. Using rvalue reference parameter in protobuf handler opts-out of arena usage, and allows the handler to move the message. Review: https://reviews.apache.org/r/63639/ {noformat} > Improve performance of protobuf message passing by removing RepeatedPtrField > to vector conversion. > -------------------------------------------------------------------------------------------------- > > Key: MESOS-6972 > URL: https://issues.apache.org/jira/browse/MESOS-6972 > Project: Mesos > Issue Type: Improvement > Reporter: Benjamin Mahler > Labels: performance, tech-debt > > Currently, all protobuf message handlers must take a {{vector}} for repeated > fields, rather than a {{RepeatedPtrField}}. > This requires that a copy be performed of the repeated field's entries (see > [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]), > which can be very expensive in some cases. We should avoid requiring this > expense on the callers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)