[ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279122#comment-16279122 ]
Michael Park commented on MESOS-6972: ------------------------------------- {noformat} commit 6839897c5464fce6b8cbd253d959a7e2efd72987 (HEAD -> master, upstream/master) Author: Dmitry Zhuk <dz...@twopensource.com> Date: Tue Dec 5 11:21:27 2017 -0800 Made `Event` move-only in libprocess. Review: https://reviews.apache.org/r/64347/ {noformat} {noformat} commit c9e6a03c02e9f8dc040b937ccd5ae89e5530fd7e Author: Dmitry Zhuk <dz...@twopensource.com> Date: Tue Dec 5 11:21:11 2017 -0800 Used `std::move` for `Event`s consumption in the master. Review: https://reviews.apache.org/r/63641/ {noformat} {noformat} commit 8014e3f9e1838745a6f3af7c1e2a557bd74349b0 Author: Dmitry Zhuk <dz...@twopensource.com> Date: Tue Dec 5 11:20:55 2017 -0800 Added `CallableOnce` support in `Future`. `Future` guarantees that callbacks are called at most once, so it can use `lambda::CallableOnce` to expicitly declare this, and allow corresponding optimizations with moves. Review: https://reviews.apache.org/r/63638/ {noformat} {noformat} commit 09b72e9bbf87793ce84df5d5f9d5f292c60fa5ee Author: Dmitry Zhuk <dz...@twopensource.com> Date: Tue Dec 5 11:20:41 2017 -0800 Added `CallableOnce` support in `defer`. This allows `defer` result to be converted to `CallableOnce`, ensuring that bound arguments are moved, when call is made, and avoiding making copies of bound arguments. Review: https://reviews.apache.org/r/63637/ {noformat} > Improve performance of protobuf message passing by removing RepeatedPtrField > to vector conversion. > -------------------------------------------------------------------------------------------------- > > Key: MESOS-6972 > URL: https://issues.apache.org/jira/browse/MESOS-6972 > Project: Mesos > Issue Type: Improvement > Reporter: Benjamin Mahler > Labels: performance, tech-debt > > Currently, all protobuf message handlers must take a {{vector}} for repeated > fields, rather than a {{RepeatedPtrField}}. > This requires that a copy be performed of the repeated field's entries (see > [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]), > which can be very expensive in some cases. We should avoid requiring this > expense on the callers. -- This message was sent by Atlassian JIRA (v6.4.14#64029)