[ https://issues.apache.org/jira/browse/MESOS-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366503#comment-16366503 ]
ASF GitHub Bot commented on MESOS-8534: --------------------------------------- Github user jieyu commented on a diff in the pull request: https://github.com/apache/mesos/pull/263#discussion_r168652041 --- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp --- @@ -721,7 +721,7 @@ Future<Option<ContainerLaunchInfo>> NetworkCniIsolatorProcess::prepare( env->set_name("LIBPROCESS_IP"); env->set_value("0.0.0.0"); - if (!containerId.has_parent()) { + if (needsSeparateNs) { --- End diff -- This should be ``` if (!isDebugContainer && (!nestedContainer || !joinParentNetwork)) ``` > Allow nested containers in TaskGroups to have separate network namespaces > ------------------------------------------------------------------------- > > Key: MESOS-8534 > URL: https://issues.apache.org/jira/browse/MESOS-8534 > Project: Mesos > Issue Type: Task > Components: containerization > Reporter: Sagar Sadashiv Patwardhan > Priority: Minor > Labels: cni > > As per the discussion with [~jieyu] and [~avinash.mesos] , I am going to > allow nested containers in TaskGroups to have separate namespaces. I am also > going to retain the existing functionality, where nested containers can share > namespaces with parent/root container. -- This message was sent by Atlassian JIRA (v7.6.3#76005)