[
https://issues.apache.org/jira/browse/MESOS-8534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366505#comment-16366505
]
ASF GitHub Bot commented on MESOS-8534:
---------------------------------------
Github user jieyu commented on a diff in the pull request:
https://github.com/apache/mesos/pull/263#discussion_r168652532
--- Diff: src/slave/containerizer/mesos/isolators/network/cni/cni.cpp ---
@@ -751,10 +751,11 @@ Future<Option<ContainerLaunchInfo>>
NetworkCniIsolatorProcess::prepare(
launchInfo.add_clone_namespaces(CLONE_NEWNET);
launchInfo.add_clone_namespaces(CLONE_NEWNS);
launchInfo.add_clone_namespaces(CLONE_NEWUTS);
+ infos[containerId]->needsSeparateNs = needsSeparateNs;
}
} else {
- // This is a nested container. This shares the parent's network
- // and UTS namespace. For non-DEBUG containers it also needs a
+ // This is a nested container and wants to share parent's network
+ // and UTS namespace. For non-DEBUG containers, it also needs a
--- End diff --
```
launchInfo.add_enter_namespaces(CLONE_NEWNET);
launchInfo.add_enter_namespaces(CLONE_NEWUTS);
if (!isDebugContainer) {
launchInfo.add_clone_namespaces(CLONE_NEWNS);
}
> Allow nested containers in TaskGroups to have separate network namespaces
> -------------------------------------------------------------------------
>
> Key: MESOS-8534
> URL: https://issues.apache.org/jira/browse/MESOS-8534
> Project: Mesos
> Issue Type: Task
> Components: containerization
> Reporter: Sagar Sadashiv Patwardhan
> Priority: Minor
> Labels: cni
>
> As per the discussion with [~jieyu] and [~avinash.mesos] , I am going to
> allow nested containers in TaskGroups to have separate namespaces. I am also
> going to retain the existing functionality, where nested containers can share
> namespaces with parent/root container.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
