[ 
https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058267#comment-16058267
 ] 

ASF GitHub Bot commented on METRON-990:
---------------------------------------

Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/613#discussion_r123368861
  
    --- Diff: 
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/templates/enrichment.properties.j2
 ---
    @@ -16,72 +16,48 @@
     # limitations under the License.
     #}
     
    -##### Kafka #####
    +##### Storm #####
    +enrichment.workers={{enrichment_workers}}
    +enrichment.acker.executors={{enrichment_acker_executors}}
    +topology.worker.childopts={{enrichment_topology_worker_childopts}}
    +topology.auto-credentials={{topology_auto_credentials}}
    +topology.max.spout.pending={{enrichment_topology_max_spout_pending}}
     
    +##### Kafka #####
     kafka.zk={{zookeeper_quorum}}
     kafka.broker={{kafka_brokers}}
    -kafka.security.protocol={{kafka_security_protocol}}
    -topology.worker.childopts={{topology_worker_childopts}}
    -topology.auto-credentials={{topology_auto_credentials}}
    -enrichment.output.topic=indexing
    -enrichment.error.topic=indexing
    -threat.intel.error.topic=indexing
    -
    -##### Metrics #####
    -
    -#reporters
    -org.apache.metron.metrics.reporter.graphite=true
    -org.apache.metron.metrics.reporter.console=false
    -org.apache.metron.metrics.reporter.jmx=false
    -
    -#Graphite Addresses
    +kafka.security.protocol=PLAINTEXT
    --- End diff --
    
    Fixed


> Clean up and organize flux properties
> -------------------------------------
>
>                 Key: METRON-990
>                 URL: https://issues.apache.org/jira/browse/METRON-990
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: Ryan Merriman
>            Assignee: Ryan Merriman
>
> There are several flux properties that are not being used anymore.  There are 
> also several hardcoded values in flux files that should be configurable.  A 
> review of the flux files is needed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to