[ https://issues.apache.org/jira/browse/METRON-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058299#comment-16058299 ]
ASF GitHub Bot commented on METRON-990: --------------------------------------- Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/613#discussion_r123372371 --- Diff: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-env.xml --- @@ -253,69 +253,295 @@ </value-attributes> </property> <property> - <name>global-json</name> - <display-name>global.json template</display-name> - <description>This is the jinja template for global.json file</description> - <value> -{ -"es.clustername": "{{ es_cluster_name }}", -"es.ip": "{{ es_url }}", -"es.date.format": "yyyy.MM.dd.HH", -"parser.error.topic": "indexing" -} - </value> + <name>es_date_format</name> + <description>Elasticsearch Date Format</description> + <value>yyyy.MM.dd.HH</value> + <display-name>Elasticsearch Date Format</display-name> + </property> + <property> + <name>parser_error_topic</name> + <description>Parser Error Topic</description> + <value>indexing</value> + <display-name>Parser Error Topic</display-name> + </property> + <property> + <name>enrichment_workers</name> --- End diff -- Great. Feel free to do as a separate PR, if you like. Definitely not needed as part of this one. > Clean up and organize flux properties > ------------------------------------- > > Key: METRON-990 > URL: https://issues.apache.org/jira/browse/METRON-990 > Project: Metron > Issue Type: Improvement > Reporter: Ryan Merriman > Assignee: Ryan Merriman > > There are several flux properties that are not being used anymore. There are > also several hardcoded values in flux files that should be configurable. A > review of the flux files is needed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)