[ 
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537338#comment-16537338
 ] 

ASF GitHub Bot commented on METRON-1650:
----------------------------------------

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1091
  
    @jameslamb, this is still failing for me.  Just to be clear, the 
"build-rpms" and "build-debs" maven profiles should be used when testing this.  
You don't necessarily have to build full dev.  When I run this command in 
metron-deployment:
    ```
    mvn clean package -DskipTests -Pbuild-rpms
    ```
    I am still getting this error:
    ```
    /var/tmp/rpm-tmp.VpikxG: line 60: npm: command not found
    error: Bad exit status from /var/tmp/rpm-tmp.VpikxG (%install)
        Macro %_prerelease has empty body
        Macro %_prerelease has empty body
        Bad exit status from /var/tmp/rpm-tmp.VpikxG (%install)
    ```
    
    I think your change may not have been pushed out correctly.  I still only 
see 1 commit in the PR when I would expect 2:  your original commit + the 
commit to fix this issue.  Because of this I'm also not able to see what you 
did to fix the error, I only see all changes.


> Packaging docker containers are too large
> -----------------------------------------
>
>                 Key: METRON-1650
>                 URL: https://issues.apache.org/jira/browse/METRON-1650
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: James Lamb
>            Priority: Minor
>
> I have been looking through the project source code, and found that the 
> packaging docker containers are bigger than they need to be. 
> The containers' size could be cut substantially by:
>  * Grouping as many commands as possible into as few RUN stages as possible
>  * Taking advantage of `yum clean` and `apt-get clean`
>  * Removing artifacts pulled with `wget`
>  * Removing unused libraries or libraries only needed at build time (like 
> `tar` and `wget`)
> I am creating this issue but will soon submit a PR to address it.
> Thank you for considering my proposal!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to