[ 
https://issues.apache.org/jira/browse/METRON-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538519#comment-16538519
 ] 

ASF GitHub Bot commented on METRON-1650:
----------------------------------------

Github user merrimanr commented on the issue:

    https://github.com/apache/metron/pull/1091
  
    I (and I expect most in our community) would prefer separate commits.  It 
makes it easier to see changes you make in response to feedback.  Also when I 
pulled your recent commits I got a merge conflict because of the forced push.  
We squash the commits when we merge a PR to master so it doesn't really matter 
anyways.  In the end it's one commit.
    
    Running the command in my previous comment should reproduce the error.


> Packaging docker containers are too large
> -----------------------------------------
>
>                 Key: METRON-1650
>                 URL: https://issues.apache.org/jira/browse/METRON-1650
>             Project: Metron
>          Issue Type: Improvement
>            Reporter: James Lamb
>            Priority: Minor
>
> I have been looking through the project source code, and found that the 
> packaging docker containers are bigger than they need to be. 
> The containers' size could be cut substantially by:
>  * Grouping as many commands as possible into as few RUN stages as possible
>  * Taking advantage of `yum clean` and `apt-get clean`
>  * Removing artifacts pulled with `wget`
>  * Removing unused libraries or libraries only needed at build time (like 
> `tar` and `wget`)
> I am creating this issue but will soon submit a PR to address it.
> Thank you for considering my proposal!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to