[
https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570845#comment-16570845
]
ASF GitHub Bot commented on METRON-1726:
----------------------------------------
GitHub user mmiklavc opened a pull request:
https://github.com/apache/metron/pull/1140
METRON-1726: Refactor PcapTopologyIntegrationTest
## Contributor Comments
https://issues.apache.org/jira/browse/METRON-1726
While working on issues with multi-threading and the pcap job I found it
useful to split up the monolithic pcap integration test into multiple tests
with a separate setup and teardown method using @Before/AfterClass. Also fixed
a regression/bug where the integration tests were writing out to the module
root instead of `target`. Added back the file output path prefix along with
defaults for the PcapCLI to write to the exec dir. Verification of this PR is
checking that the tests appear correct and that the integration test passes.
## Pull Request Checklist
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
n/a
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mmiklavc/metron pcap-integration-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1140.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1140
----
commit 33d3c302e3eccaa525877475a5d43dcbe9437188
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-08-06T21:48:19Z
Refactor pcap integration test - split each test into its own method.
commit a9480a365e760be586cd68a57e08395fbe618e46
Author: Michael Miklavcic <michael.miklavcic@...>
Date: 2018-08-03T21:38:48Z
Fix output path for integration tests
----
> Refactor PcapTopologyIntegrationTest
> ------------------------------------
>
> Key: METRON-1726
> URL: https://issues.apache.org/jira/browse/METRON-1726
> Project: Metron
> Issue Type: Sub-task
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
