[
https://issues.apache.org/jira/browse/METRON-1726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16572153#comment-16572153
]
ASF GitHub Bot commented on METRON-1726:
----------------------------------------
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1140
First off, I think this is definitely an improvement. Putting the
individual pcap queries into separate tests makes it easier to understand when
things go wrong.
Would it make sense to move the pcap job/query related code to it's own
test? For me it makes more sense to have these tests in something like
PcapJobIntegrationTest in metron-pcap. It feels awkward for the pcap topology
test to be in a setup or `@BeforeClass` method. If I introduced a bug to the
pcap topology code, which test would fail?
What do you think?
> Refactor PcapTopologyIntegrationTest
> ------------------------------------
>
> Key: METRON-1726
> URL: https://issues.apache.org/jira/browse/METRON-1726
> Project: Metron
> Issue Type: Sub-task
> Reporter: Michael Miklavcic
> Assignee: Michael Miklavcic
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
