Github user merrimanr commented on a diff in the pull request:

    https://github.com/apache/metron/pull/1165#discussion_r210306554
  
    --- Diff: 
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
 ---
    @@ -179,19 +171,6 @@ describe('PcapFiltersComponent', () => {
         component.onSubmit();
       });
     
    -  it('Port fields should be removed from request when set to empty', () => 
{
    --- End diff --
    
    Why was this test removed?  This was added to catch a regression introduced 
in a previous PR.  Now this test is gone and the regression is back!


---

Reply via email to