Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1165#discussion_r210379924
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
- startTimeMs: number = 0;
- endTimeMs: number = 150000000000000000;
- ipSrcAddr: string = '';
- ipSrcPort: number;
- ipDstAddr: string = '';
- ipDstPort: number;
- protocol: string = '';
- packetFilter: string = '';
- includeReverse: boolean = false;
+ startTimeMs = 0;
+ endTimeMs = 150000000000000000;
+ ipSrcAddr = '';
+ ipSrcPort = 0;
--- End diff --
These default values was part of the handovered implementation. It haven't
caused issues till now. Anyway these defaults makes no sense to me eigther.
I'll fix it retest against the latest full dev.
---
