justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348642607
##########
File path:
metron-platform/metron-management/src/test/java/org/apache/metron/management/FileSystemFunctionsTest.java
##########
@@ -101,75 +114,74 @@ public void setup() throws IOException {
rm.initialize(null);
}
- @AfterClass
- public static void teardown() {
- {
- hdfsCluster.shutdown();
- FileUtil.fullyDelete(hdfsBaseDir);
- }
- {
- new File(localPrefix).delete();
- }
- }
-
- @Test
- public void testHappyPath() {
+ @ParameterizedTest
+ @MethodSource("types")
+ public void testHappyPath(FileSystemFunctions.FS_TYPE type) {
+ setupFsTypeAndFunctions(type);
Review comment:
It's another artifact of moving away from `@Parameterized`. The parameter
comes in as an arg to the actual test method itself, so it's not available in
`@Before`/`@BeforeEach`, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
