justinleet commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r349243107
##########
File path:
metron-platform/metron-solr/metron-solr-common/src/test/java/org/apache/metron/solr/dao/SolrSearchDaoTest.java
##########
@@ -255,11 +210,11 @@ public void getAllLatestShouldProperlyReturnDocuments()
throws Exception {
SolrDocumentList snortList = new SolrDocumentList();
snortList.add(snortSolrDoc1);
snortList.add(snortSolrDoc2);
- when(client.getById((Collection<String>) argThat(hasItems("bro-1",
"bro-2")),
+ when(client.getById((List<String>)
org.mockito.hamcrest.MockitoHamcrest.argThat(hasItems("bro-1", "bro-2")),
Review comment:
Unfortunately, I don't believe so. The `hasItems` doesn't play nice with the
plain `argThat` interfaces, which necessitates using the `MockitoHamcrest` in
this case. I believe this is only instance of this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
