mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to JUnit5 URL: https://github.com/apache/metron/pull/1554#discussion_r349218988
########## File path: pom.xml ########## @@ -111,21 +111,21 @@ <global_elasticsearch_version>5.6.14</global_elasticsearch_version> <global_json_simple_version>1.1.1</global_json_simple_version> <global_metrics_version>3.0.2</global_metrics_version> - <global_junit_version>4.12</global_junit_version> + <global_junit_jupiter_version>5.5.2</global_junit_jupiter_version> + <global_hamcrest_version>2.2</global_hamcrest_version> <global_guava_version>17.0</global_guava_version> <global_hbase_guava_version>12.0</global_hbase_guava_version> <global_json_schema_validator_version>2.2.5</global_json_schema_validator_version> <global_slf4j_version>1.7.7</global_slf4j_version> <global_opencsv_version>3.7</global_opencsv_version> <global_java_version>1.8</global_java_version> <global_solr_version>6.6.2</global_solr_version> - <global_mockito_version>1.10.19</global_mockito_version> - <global_powermock_version>1.7.0</global_powermock_version> + <global_mockito_version>3.1.0</global_mockito_version> <global_shade_version>3.2.0</global_shade_version> <global_jackson_version>2.7.4</global_jackson_version> <global_errorprone_core_version>2.0.14</global_errorprone_core_version> <global_jar_version>3.0.2</global_jar_version> - <global_surefire_version>2.18</global_surefire_version> + <global_surefire_version>3.0.0-M3</global_surefire_version> Review comment: Should we consider M4? https://maven.apache.org/surefire/maven-surefire-plugin/index.html > Provided 3 extensions of reporters which can be used to customize XML report, console and file reporters. It is very useful for JUnit5 users. > We reworked the internal implementation so that new commands and events can be easily added. The impl is located in a center point and it is a prerequisite in next versions. > Provided bug fixes for Docker Alpine/BusyBox Linux, JUnit5 and 43 more. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services