mmiklavc commented on a change in pull request #1554: METRON-2307: Migrate to
JUnit5
URL: https://github.com/apache/metron/pull/1554#discussion_r348194133
##########
File path:
metron-platform/metron-management/src/test/java/org/apache/metron/management/FileSystemFunctionsTest.java
##########
@@ -78,8 +77,23 @@ public static void setupFS() throws IOException {
}
}
- @Before
- public void setup() throws IOException {
+ @BeforeEach
+ public void setup() {
Review comment:
See other comment below regarding `setupFsTypeAndFunctions(type);`. If it
makes sense to keep those as-is, then it might make sense to delete this method
altogether.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
