adamdebreceni commented on a change in pull request #861:
URL: https://github.com/apache/nifi-minifi-cpp/pull/861#discussion_r465518803
##########
File path: libminifi/test/flow-tests/FlowControllerTests.cpp
##########
@@ -133,12 +144,9 @@ TEST_CASE("Flow shutdown waits for a while",
"[TestFlow2]") {
testController.startFlow();
// wait for the source processor to enqueue its flowFiles
- int tryCount = 0;
- while (tryCount++ < 10 && root->getTotalFlowFileCount() != 3) {
- std::this_thread::sleep_for(std::chrono::milliseconds{20});
- }
+ busy_wait(std::chrono::milliseconds{50}, [&] {return
root->getTotalFlowFileCount() != 0;});
Review comment:
@hunyadi-dev I don't see why it should be compile-time decidable if we
need sleep but alright will not add an extra parameter, @fgerlits could you
expand on your proposal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
