adamdebreceni commented on a change in pull request #861:
URL: https://github.com/apache/nifi-minifi-cpp/pull/861#discussion_r466186234
##########
File path: libminifi/test/flow-tests/FlowControllerTests.cpp
##########
@@ -215,20 +220,19 @@ TEST_CASE("Extend the waiting period during shutdown",
"[TestFlow4]") {
testController.startFlow();
// wait for the source processor to enqueue its flowFiles
- int tryCount = 0;
- while (tryCount++ < 10 && root->getTotalFlowFileCount() != 3) {
- std::this_thread::sleep_for(std::chrono::milliseconds{20});
- }
+ busy_wait(std::chrono::milliseconds{50}, [&] {return
root->getTotalFlowFileCount() != 0;});
- REQUIRE(root->getTotalFlowFileCount() == 3);
+ REQUIRE(root->getTotalFlowFileCount() != 0);
REQUIRE(sourceProc->trigger_count.load() == 1);
std::thread shutdownThread([&]{
execSinkPromise.set_value();
controller->stop(true);
});
- while (controller->isRunning()) {
+ int extendCount = 0;
+ while (extendCount++ < 5 && controller->isRunning()) {
Review comment:
note that here we are not simply waiting for the controller to shutdown,
but we are verifying if we can progressively delay the shutdown by adjusting
the timeout parameter, shorter sleeps seem to be relatively more imprecise than
longer ones on the agents, I understand now that this might cause confusion,
will add some check to better convey its purpose
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
