hunyadi-dev commented on a change in pull request #866:
URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468413003
##########
File path: extensions/libarchive/MergeContent.h
##########
@@ -43,6 +43,8 @@ namespace processors {
#define MERGE_FORMAT_AVRO_VALUE "Avro"
#define DELIMITER_STRATEGY_FILENAME "Filename"
#define DELIMITER_STRATEGY_TEXT "Text"
+#define ATTRIBUTE_STRATEGY_KEEP_COMMON "Keep Only Common Attributes"
+#define ATTRIBUTE_STRATEGY_KEEP_ALL_UNIQUE "Keep All Unique Attributes"
Review comment:
I am not too fond of having these as defines. Maybe they belong under
`MergeContent` or `BinFiles` as `static constexpr const char*`-s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
