lordgamez commented on a change in pull request #866:
URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468422943
##########
File path: extensions/libarchive/MergeContent.h
##########
@@ -259,6 +261,42 @@ class ZipMerge: public ArchiveMerge, public MergeBin {
}
};
+class AttributeMerger {
+public:
+ AttributeMerger(core::ProcessSession *session,
std::deque<std::shared_ptr<org::apache::nifi::minifi::core::FlowFile>> &flows,
std::shared_ptr<core::FlowFile> &mergeFlow)
+ : session_(session)
+ , flows_(flows)
+ , mergeFlow_(mergeFlow) {}
+ void mergeAttributes();
+ virtual ~AttributeMerger() = default;
+protected:
+ std::map<std::string, std::string> getCommonAttributes();
+ virtual void processFlowFile(const std::shared_ptr<core::FlowFile> &flow,
std::map<std::string, std::string>& commonAttributes) = 0;
+
+ std::deque<std::shared_ptr<core::FlowFile>> &flows_;
Review comment:
What would be the benefit using a raw pointer over shared_ptr& here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
