lordgamez commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r543193837
##########
File path: libminifi/test/persistence-tests/PersistenceTests.cpp
##########
@@ -326,10 +334,12 @@ TEST_CASE("Persisted flowFiles are updated on
modification", "[TestP1]") {
ff_repository->start();
// wait for FlowFileRepository to start and notify the owners of
// the resurrected FlowFiles
- std::this_thread::sleep_for(std::chrono::milliseconds{100});
-
std::set<std::shared_ptr<core::FlowFile>> expired;
- auto file = flow.output->poll(expired);
+ std::shared_ptr<org::apache::nifi::minifi::core::FlowFile> file = nullptr;
+ for (auto i = 0; i < 20 && !file; ++i) {
Review comment:
Additional fix in
[7118255](https://github.com/apache/nifi-minifi-cpp/pull/959/commits/71182553d44298eb0e2f400425d0133995410b45)
as we still need an additional wait for the flowfile repository to start in
the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
