hunyadi-dev commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r543362773
##########
File path: extensions/rocksdb-repos/FlowFileRepository.h
##########
@@ -61,10 +61,11 @@ class FlowFileRepository : public core::Repository, public
std::enable_shared_fr
: FlowFileRepository(name) {
}
- FlowFileRepository(const std::string repo_name = "", std::string directory =
FLOWFILE_REPOSITORY_DIRECTORY, int64_t maxPartitionMillis =
MAX_FLOWFILE_REPOSITORY_ENTRY_LIFE_TIME,
+ FlowFileRepository(const std::string repo_name = "", std::string
checkpoint_dir = FLOWFILE_CHECKPOINT_DIRECTORY, std::string directory =
FLOWFILE_REPOSITORY_DIRECTORY, int64_t maxPartitionMillis =
MAX_FLOWFILE_REPOSITORY_ENTRY_LIFE_TIME,
Review comment:
Minor, but why not const ref strings?
##########
File path: extensions/rocksdb-repos/FlowFileRepository.h
##########
@@ -61,10 +61,11 @@ class FlowFileRepository : public core::Repository, public
std::enable_shared_fr
: FlowFileRepository(name) {
}
- FlowFileRepository(const std::string repo_name = "", std::string directory =
FLOWFILE_REPOSITORY_DIRECTORY, int64_t maxPartitionMillis =
MAX_FLOWFILE_REPOSITORY_ENTRY_LIFE_TIME,
+ FlowFileRepository(const std::string repo_name = "", std::string
checkpoint_dir = FLOWFILE_CHECKPOINT_DIRECTORY, std::string directory =
FLOWFILE_REPOSITORY_DIRECTORY, int64_t maxPartitionMillis =
MAX_FLOWFILE_REPOSITORY_ENTRY_LIFE_TIME,
Review comment:
Minor, but why not const references for strings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
