hunyadi-dev commented on a change in pull request #1020: URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585302260
########## File path: CMakeLists.txt ########## @@ -315,11 +313,28 @@ target_compile_definitions(gsl-lite INTERFACE ${GslDefinitions}) # optional-lite add_library(optional-lite INTERFACE) -target_include_directories(optional-lite INTERFACE "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/optional-lite-3.2.0/include") +target_include_directories(optional-lite SYSTEM INTERFACE "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/optional-lite-3.2.0/include") # date include(Date) +# Setup passthrough args used by third parties +set(PASSTHROUGH_CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) +set(PASSTHROUGH_CMAKE_C_FLAGS ${CMAKE_C_FLAGS}) + +# Setup warning flags +if(MSVC) + if(FAIL_ON_WARNINGS) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /WX") + endif() +else() Review comment: Minor, but omitting the `FAIL_ON_WARNINGS_FLAG` variable would probably be more readable: ```cmake else() set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra") if(FAIL_ON_WARNINGS) set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror") endif() endif() ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org