hunyadi-dev commented on a change in pull request #1020:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1020#discussion_r585334734
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -407,7 +407,7 @@ class ReadCallback : public InputStreamCallback {
return 0;
}
- for (size_t segment_num = 0; read_size_ < flow_size_; ++segment_num) {
+ for (size_t segment_num = 0; gsl::narrow<uint32_t>(read_size_) <
flow_size_; ++segment_num) {
Review comment:
Can we not actually change the `read_size_` type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
