hunyadi-dev commented on a change in pull request #1013:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1013#discussion_r589434954
##########
File path: libminifi/src/Connection.cpp
##########
@@ -227,8 +212,7 @@ void Connection::drain(bool delete_permanently) {
std::lock_guard<std::mutex> lock(mutex_);
Review comment:
Might be not related to this PR, but are we happy just locking here? Can
we not resume a blocked insertion after the queue is supposedly drained?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
