fgerlits commented on a change in pull request #1013:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1013#discussion_r589450106
##########
File path: libminifi/src/Connection.cpp
##########
@@ -227,8 +212,7 @@ void Connection::drain(bool delete_permanently) {
std::lock_guard<std::mutex> lock(mutex_);
Review comment:
I don't think we can (or want to) stop new flow files from being added
to the connection queue after a `drain()`, and I would say a `put()` which
resumes after it has acquired the lock happens after the `drain()`, even if it
started before.
But yes, I agree it's not related to this change. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
