lordgamez commented on a change in pull request #1029:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1029#discussion_r594988935
##########
File path: run_flake8.sh
##########
@@ -0,0 +1,6 @@
+#!/bin/bash
+
+set -euo pipefail
+
+directory=${1:-.}
+flake8 --exclude thirdparty,build --ignore E501,W504
--per-file-ignores="steps.py:F811" "${directory}"
Review comment:
Flake8 has both [W503](https://www.flake8rules.com/rules/W503.html) and
[W504](https://www.flake8rules.com/rules/W504.html) enabled by default and they
contradict each other. We have to choose one of them to use, in this case I
chose to use W503 and ignore W504 to have the binary operators at the end of
the line.
[F811](https://www.flake8rules.com/rules/F811.html) is only ignored in
steps.py as it defines the `behave` framework steps. This file has the same
`step_impl` function name for each step and `flake8` detects it as a
redefinition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
