szaszm commented on a change in pull request #1029:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1029#discussion_r596247190
##########
File path: docker/test/integration/minifi/processors/DeleteS3Object.py
##########
@@ -1,13 +1,16 @@
from ..core.Processor import Processor
+
class DeleteS3Object(Processor):
- def __init__(self,
- proxy_host = '',
- proxy_port = '',
- proxy_username = '',
- proxy_password = ''):
- super(DeleteS3Object, self).__init__('DeleteS3Object',
- properties = {
+ def __init__(
+ self,
Review comment:
why not one level: to clearly separate it from normal code one layer
deeper
why not aligned: to support find/replace and rename refactoring without
messing up the layout
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
