adamdebreceni commented on a change in pull request #1052: URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r619055105
########## File path: extensions/standard-processors/processors/TailFile.cpp ########## @@ -609,6 +640,10 @@ std::vector<TailState> TailFile::findRotatedFiles(const TailState &state) const utils::file::FileUtils::list_dir(state.path_, collect_matching_files, logger_, false); + return findRotatedFiles(state, matched_files_with_mtime); +} + +std::vector<TailState> TailFile::findRotatedFiles(const TailState &state, std::vector<TailStateWithMtime>& matched_files_with_mtime) const { Review comment: this might be a misleading name, a `sortAndSkipMainFilePrefix` or some similar contraption could better describe its function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org