lordgamez commented on a change in pull request #1052:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1052#discussion_r622268250



##########
File path: extensions/standard-processors/processors/TailFile.h
##########
@@ -147,13 +166,27 @@ class TailFile : public core::Processor {
 
   std::string rolling_filename_pattern_;
 
+  InitialStartPositions initial_start_position_;
+
+  bool first_trigger_{true};

Review comment:
       We have a `lock_guard` using the `tail_file_mutex_` data member at the 
beginning of the `onTrigger` (also at the beginning of `onSchedule` I'm not 
sure if that's necessary), so it should not be a problem.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to