adamdebreceni commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r619077556
##########
File path: extensions/http-curl/tests/CMakeLists.txt
##########
@@ -68,6 +68,7 @@ message("-- Finished building ${CURL_INT_TEST_COUNT} libcURL
integration test fi
add_test(NAME HTTPClientTests COMMAND "HTTPClientTests" WORKING_DIRECTORY
${TEST_DIR})
add_test(NAME HTTPStreamingCallbackTests COMMAND "HTTPStreamingCallbackTests"
WORKING_DIRECTORY ${TEST_DIR})
+add_test(NAME InvokeHTTPTests COMMAND "InvokeHTTPTests" WORKING_DIRECTORY
${TEST_DIR})
Review comment:
a few lines above, we have a loop iterating over the unit tests,
(`HTTPClientTests`, `HTTPStreamingCallbackTests`, `InvokeHTTPTests`) and there
is a commented out `add_test`, should we uncomment that instead and remove
these three here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
