szaszm commented on a change in pull request #1059:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1059#discussion_r619216945
##########
File path: extensions/http-curl/tests/CMakeLists.txt
##########
@@ -40,8 +40,8 @@ FOREACH(testfile ${CURL_UNIT_TESTS})
target_wholearchive_library(${testfilename} minifi-civet-extensions)
target_wholearchive_library(${testfilename} minifi-standard-processors)
- MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")
-# add_test(NAME "${testfilename}" COMMAND "${testfilename}"
WORKING_DIRECTORY ${TEST_DIR})
+ MATH(EXPR CURL_INT_TEST_COUNT "${CURL_INT_TEST_COUNT}+1")
Review comment:
What was the goal here? Previously we had 2 spaces + 1 tab, now 1 space
+ 1 tab. Both are incorrect IMO. The file seems to be using tabs for
indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
