szaszm commented on a change in pull request #1057:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635293708



##########
File path: libminifi/src/Configure.cpp
##########
@@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& 
value) const {
 
 bool Configure::get(const std::string& key, const std::string& alternate_key, 
std::string& value) const {
   if (get(key, value)) {
+    if (get(alternate_key)) {
+      const auto logger = logging::LoggerFactory<Configure>::getLogger();
+      logger->log_warn("Both the property '%s' and an alternate property '%s' 
are set. Using '%s'.", key, alternate_key, key);

Review comment:
       Is this function only used in those cases? My impression was just a 
general function with a fallback key option, as the signature doesn't imply 
`alternate_key` being deprecated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to