[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1093: MINIFICPP-1578 Upgrade OS versions in docker builds

[GitBox]

lordgamez commented on a change in pull request #1093:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1093#discussion_r643800567



##########
File path: docker/DockerBuild.sh
##########
@@ -113,20 +113,19 @@ else
   DOCKERFILE="Dockerfile"
 fi
 
-TAG=""
+TAG="${MINIFI_VERSION}"
+
 if [ "${IMAGE_TYPE}" != "release" ]; then
-  TAG="${IMAGE_TYPE}-"
+  TAG="${TAG}-${IMAGE_TYPE}"

Review comment:
       Switching the order of the version and image type could break some 
scripts depending on the `minimal-<version>` tag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org