[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1093: MINIFICPP-1578 Upgrade OS versions in docker builds

[GitBox]

fgerlits commented on a change in pull request #1093:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1093#discussion_r644102891



##########
File path: docker/DockerBuild.sh
##########
@@ -113,20 +113,19 @@ else
   DOCKERFILE="Dockerfile"
 fi
 
-TAG=""
+TAG="${MINIFI_VERSION}"
+
 if [ "${IMAGE_TYPE}" != "release" ]; then
-  TAG="${IMAGE_TYPE}-"
+  TAG="${TAG}-${IMAGE_TYPE}"

Review comment:
       I have reverted the change to `TAG` in 
https://github.com/apache/nifi-minifi-cpp/pull/1093/commits/7b768106e299b922df5192ecc02ff73287f69f46




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org