martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644072659
########## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ########## @@ -127,8 +129,8 @@ core::Property ConsumeWindowsEventLog::EventHeaderDelimiter( core::Property ConsumeWindowsEventLog::EventHeader( core::PropertyBuilder::createProperty("Event Header")-> isRequired(false)-> - withDefaultValue("LOG_NAME=Log Name, SOURCE = Source, TIME_CREATED = Date,EVENT_RECORDID=Record ID,EVENTID = Event ID,TASK_CATEGORY = Task Category,LEVEL = Level,KEYWORDS = Keywords,USER = User,COMPUTER = Computer, EVENT_TYPE = EventType")-> - withDescription("Comma seperated list of key/value pairs with the following keys LOG_NAME, SOURCE, TIME_CREATED,EVENT_RECORDID,EVENTID,TASK_CATEGORY,LEVEL,KEYWORDS,USER,COMPUTER, and EVENT_TYPE. Eliminating fields will remove them from the header.")-> + withDefaultValue("LOG_NAME=Log Name, SOURCE = Source, TIME_CREATED = Date,EVENT_RECORDID=Record ID,EVENTID = Event ID,TASK_CATEGORY = Task Category,LEVEL = Level,KEYWORDS = Keywords,USER = User,COMPUTER = Computer, EVENT_TYPE = EventType")-> // NOLINT linelength + withDescription("Comma seperated list of key/value pairs with the following keys LOG_NAME, SOURCE, TIME_CREATED,EVENT_RECORDID,EVENTID,TASK_CATEGORY,LEVEL,KEYWORDS,USER,COMPUTER, and EVENT_TYPE. Eliminating fields will remove them from the header.")-> // NOLINT linelength Review comment: Splitting them like this seems like a common practice in this extension. https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/windows-event-log/ConsumeWindowsEventLog.cpp#L81-L95 So at least now we would be consistent with the style used here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org