martinzink commented on a change in pull request #1089:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644128074
##########
File path: extensions/windows-event-log/wel/JSONUtils.h
##########
@@ -20,9 +20,10 @@
#undef RAPIDJSON_ASSERT
#define RAPIDJSON_ASSERT(x) if (!(x)) throw std::logic_error("rapidjson
exception"); // NOLINT
-#include <pugixml.hpp>
-
#include <stdexcept> // for std::logic_error
+#include <string>
Review comment:
It turns out its needed in the header, because in line 21
RAPIDJSON_ASSERT is redefined as std::logic so the rapidjson include needs the
stdexcept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
