szaszm commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708274224
##########
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##########
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
-#ifdef WIN32
-constexpr const char* DEFAULT_NIFI_BOOTSTRAP_FILE = "\\conf\\bootstrap.conf";
Review comment:
This was because I changed concat_path to use std::filesystem::path /=,
and concatenating "\conf\bootstrap.conf" (an absolute path) to anything results
in this second part overwriting the path of the first. This is indeed a
behavior change that would ideally not be part of this PR. The reason it is is
that I started with this change in the same working directory and I wanted to
avoid separating the changes if I could get away leaving them as they are.
##########
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##########
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
-#ifdef WIN32
-constexpr const char* DEFAULT_NIFI_BOOTSTRAP_FILE = "\\conf\\bootstrap.conf";
Review comment:
This was because I changed concat_path to use std::filesystem::path /=,
and concatenating "\conf\bootstrap.conf" (an absolute path) to anything results
in this second part overwriting the path of the first. This is indeed a
behavior change that would ideally not be part of this PR. The reason it is is
that I started with this change in the same working directory and I wanted to
avoid separating the changes if I could get away with leaving them as they are.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
