szaszm commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708276932



##########
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##########
@@ -32,11 +32,7 @@ namespace minifi {
 namespace utils {
 namespace crypto {
 
-#ifdef WIN32
-constexpr const char* DEFAULT_NIFI_BOOTSTRAP_FILE = "\\conf\\bootstrap.conf";

Review comment:
       I would still prefer not separating them, so unless you insist, I would 
prefer to have these two independent changes reviewed together. Of course this 
only works if all changes are acceptable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to