Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r84488138
--- Diff:
minifi-toolkit/minifi-toolkit-configuration/src/main/java/org/apache/nifi/minifi/toolkit/configuration/ConfigMain.java
---
@@ -96,13 +99,21 @@ public int validate(String[] args) {
}
try (InputStream inputStream =
pathInputStreamFactory.create(args[1])) {
try {
- ConfigSchema configSchema =
SchemaLoader.loadConfigSchemaFromYaml(inputStream);
+ ConvertableSchema<ConfigSchema> configSchema =
SchemaLoader.loadConvertableSchemaFromYaml(inputStream);
if (!configSchema.isValid()) {
configSchema.getValidationIssues().forEach(s ->
System.out.println(s));
System.out.println();
return ERR_INVALID_CONFIG;
} else {
-
System.out.println(NO_VALIDATION_ERRORS_FOUND_IN_TEMPLATE);
+ ConfigSchema currentSchema = configSchema.convert();
--- End diff --
Would it make sense to convert and show any validation errors even if it's
not valid in the old version?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
