Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/45#discussion_r84528235
--- Diff:
minifi-commons/minifi-commons-schema/src/main/java/org/apache/nifi/minifi/commons/schema/serialization/SchemaLoader.java
---
@@ -30,13 +32,13 @@
import java.util.stream.Collectors;
public class SchemaLoader {
- private static final Map<String, Function<Map, ConfigSchema>>
configSchemaFactories = initConfigSchemaFactories();
+ private static final Map<String, Function<Map,
ConvertableSchema<ConfigSchema>>> configSchemaFactories =
initConfigSchemaFactories();
- private static Map<String, Function<Map, ConfigSchema>>
initConfigSchemaFactories() {
- Map<String, Function<Map, ConfigSchema>> result = new HashMap<>();
- result.put(String.valueOf((Object)null), ConfigSchema::new);
- result.put("", ConfigSchema::new);
- result.put("1", ConfigSchema::new);
--- End diff --
The changes in the Config schemas need to be documented. Could you add a
section to the admin guide (the Config Schema portion) that explains the
versioning scheme as well as what changed in v2?
I am suggesting to put it in the docs instead of a migration guidance for a
release because working with multiple different version of MiNiFi and configs
will be an everyday task (esp when C&C is added).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
